Updated Apps layout to use panels #3117

Merged
merged 1 commit into from Feb 29, 2016

Projects

None yet

4 participants

@richardlawley
Contributor

The App pages were still using a table-based layout (e.g. included TR when there is no open table). This PR updates them to use the same markup style used on the Graphs pages, using a bootstrap panel.

BEFORE: before AFTER: after

I've only got memcached and mysql installed locally so unable to test the other apps, but I only replaced markup which looked identical to those on the mysql/memcache pages.

@richardlawley richardlawley Updated Apps layout to use panels
6f61ec3
@arjitc
Contributor
arjitc commented Feb 29, 2016

👍 looks much better and in-style with the rest.

@laf
Member
laf commented Feb 29, 2016

We could do with moving printing out these panels to a function maybe but it's not a critical issue so merging. Thanks @richardlawley

@laf laf added the WebUI label Feb 29, 2016
@laf laf merged commit 282ac48 into librenms:master Feb 29, 2016

2 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 7 new issues
Details
@richardlawley richardlawley deleted the richardlawley:app-page-layout branch Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment