Historical Billing Graphs use correct values for 95th line #3195

Merged
merged 1 commit into from Mar 10, 2016

Projects

None yet

3 participants

@richardlawley
Contributor

This PR changes the historical view of billing so that the graphs are called with a bill_hist_id param instead of from and to. This is used to look up the 95th percentile line and draw this on the graph. This means that when viewing the billing graph for previous months, the relevant 95th percentile line will be drawn on instead of the current value.

This may conflict with #3194 - I'll update whichever one of those gets done second if so!

@richardlawley richardlawley Make billing graphs take times from bill_hist_id and use that for 95th
069c067
@laf
Member
laf commented Mar 8, 2016

Easier to rebase this one I expect so shall hang fire.

@laf laf added WebUI Billing labels Mar 8, 2016
@richardlawley
Contributor

Turns out this didn't clash and no rebase is required.

@laf laf merged commit d996a7a into librenms:master Mar 10, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richardlawley richardlawley deleted the richardlawley:issue-3151 branch Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment