Check the sysObjectID before trying to detect ILO temp sensors. #3204

Merged
merged 1 commit into from Mar 9, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Mar 9, 2016

What do you think of this fix? To simple or just incorrect?

issue #3107

@murrant murrant Check the sysObjectID before trying to detect ILO temp sensors.
55002ac
@Rosiak
Contributor
Rosiak commented Mar 9, 2016

👍

@laf laf added the Discovery label Mar 9, 2016
@laf
Member
laf commented Mar 9, 2016

If 1.3.6.1.4.1.232 is a relevant oid then yeah looks good.

@murrant
Contributor
murrant commented Mar 9, 2016

TIL: adding ?w=1 to the github url makes the diff ignore whitespace.

After some more checks, I think this is good to merge.
👍

@laf
Member
laf commented Mar 9, 2016

Handy tip :)

@laf laf merged commit aa0a59b into librenms:master Mar 9, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:hpilo branch Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment