Add web config option for HTML emails #3221

Merged
merged 1 commit into from Mar 16, 2016

Projects

None yet

4 participants

@ekoyle
Contributor
ekoyle commented Mar 11, 2016

Add a config option with all the other alerting options for HTML emails. I don't think the existing option worked, because $config['transports'][mail] = 1 instead of an array.

@laf
Member
laf commented Mar 13, 2016

All good, tested with both html on and off and the correct content-type is set in the emails.

We need something adding to the docs so people know:

http://docs.librenms.org/Extensions/Alerting/#templates

If you can add something in then we can merge.

@ekoyle ekoyle Add web config option for HTML emails
6a53bcf
@ekoyle
Contributor
ekoyle commented Mar 15, 2016

@laf: Documented, rebased, using schema 108 instead of 107.

@ekoyle ekoyle referenced this pull request Mar 15, 2016
Merged

Alert template transport #3148

@laf
Member
laf commented Mar 16, 2016

@f0o Any thoughts on this. I've tested both on and off and it sets the content-type correctly.

@laf laf removed the Blocker label Mar 16, 2016
@f0o f0o merged commit 57339c4 into librenms:master Mar 16, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ekoyle
Contributor
ekoyle commented Mar 16, 2016

@Mattz0r: you will need to update your config now that this PR has been merged

@ekoyle ekoyle deleted the ekoyle:add_web_html_email_option branch Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment