Basic Cumulus Linux support #3237

Merged
merged 4 commits into from Mar 18, 2016

Projects

None yet

5 participants

@xbeaudouin
Contributor

Hi,

Here is a basic Cumulus Linux support. More later, but this allow Librenms to detect Cumulus Linux Switches as is.

xbeaudouin added some commits Mar 14, 2016
@xbeaudouin xbeaudouin Adding Cumulus Linux mibs 7e4718c
@xbeaudouin xbeaudouin Basic Cumulus Linux detection
77a5918
@paulgear
Member

Seems reasonable to me; anyone available to test?

@xbeaudouin
Contributor

I have done this using my s6000 at work :D

@laf laf and 1 other commented on an outdated diff Mar 15, 2016
includes/discovery/os/linux.inc.php
@@ -64,6 +64,9 @@
);
register_mibs($device, $pktj_mibs, "include/discovery/os/linux.inc.php");
}
+ else if (stristr($sysObjectId, 'cumulusMib') || strstr($sysObjectId, '.1.3.6.1.4.1.40310')) {
@laf
laf Mar 15, 2016 Member

Can you change this to elseif please.

@laf laf and 1 other commented on an outdated diff Mar 15, 2016
includes/definitions.inc.php
@@ -240,6 +240,18 @@
$config['os'][$os]['over'][2]['graph'] = 'device_mempool';
$config['os'][$os]['over'][2]['text'] = 'Memory Usage';
+$os = 'cumulus';
+$config['os'][$os]['type'] = 'network';
+$config['os'][$os]['group'] = 'unix';
+$config['os'][$os]['text'] = 'Cumulus Linux';
+//$config['os'][$os]['icon'] = 'cumulus';
@laf
laf Mar 15, 2016 Member

May as well remove this if it's not needed

@xbeaudouin
xbeaudouin Mar 15, 2016 Contributor

Well, I am waiting for an official green light to push the icon from Cumulus Network.
Do I remove until I get it ? Please advise.

@xbeaudouin xbeaudouin Change else if to elseif as requested by @laf.
ac9c428
@xbeaudouin xbeaudouin Add cumulus icon
571ee16
@laf
Member
laf commented Mar 16, 2016

👍

@xbeaudouin
Contributor

Hi ! Is there anything missing on this ? :D
Regards,
Xavier

@laf laf merged commit bcafac5 into librenms:master Mar 18, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dorkmatt
Contributor
dorkmatt commented Apr 8, 2016

Couple questions (former @cumulusnetworks employee and active user of Cumulus Linux with @sfmix), I haven't seen the sysObjectId return back 'cumulusMib' before - the enterprise ID should be enough?

Also, I slacked on merging in a version of this from my own repo - see dorkmatt@25acd8c Can we consider the close-up logo, I can hardly see the version here that is committed. Thank you.

@laf
Member
laf commented Apr 10, 2016

@dorkmatt thanks for the comments. Feel free to submit an updated PR with the logo update.

@xbeaudouin any thoughts on the sysObjectID?

@dorkmatt dorkmatt referenced this pull request Jan 21, 2017
Closed

Cumulus Networks logo #5535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment