Added Cambium Support #3279

Merged
merged 5 commits into from Mar 29, 2016

Projects

None yet

3 participants

@pheinrichs
Contributor

Added Cambium Support with multiple custom graphs
New Supported devices

  • PTP650
  • PTP450
  • PTP250
  • PTP230
  • PTP100
  • ePTP
  • Cambium(fsk,epmp,450) SM/AP

Also added signal sensor, and setup sensor for these devices

pheinrichs added some commits Mar 22, 2016
@pheinrichs pheinrichs Adding cambium MIBS 6ad3375
@pheinrichs pheinrichs Added Cambium Support 72b9fd4
@pheinrichs pheinrichs Added Signal Sensor
a13d148
@pheinrichs pheinrichs Removing Old Canopy Files
0a2b115
@laf laf commented on the diff Mar 24, 2016
includes/definitions.inc.php
@@ -1363,7 +1363,7 @@
$config['os'][$os]['icon'] = 'hikvision';
// Canopy / Cambium support
-$os = 'canopy';
@laf
laf Mar 24, 2016 Member

Unless canopy isn't valid then I'd have thought this needs to stay?

@pheinrichs
pheinrichs Mar 24, 2016 Contributor

Canopy is only labeled for the FSK and 450 equipment. When it came to the ptp 650/250 or the epmp equipment they wouldn't be considered canopy so it seemed more appropriate to generalize them all as cambium. The same detection that was being used for those canopy is still in place.

@laf
laf Mar 24, 2016 Member

Please keep in mind $os is for naming the OS that a device runs not the company or product range. So for cisco we have ios, iosxe, etc.

@pheinrichs
pheinrichs Mar 24, 2016 Contributor

Noted, in that sense. It would be divided into 2 OS's if this is okay.
Canopy OS:
Cambium fsk,450 SM/AP

Cambium OS:
PTP650
PTP250
ePTP

Those devices under the cambium don't have any OS that i can really label them besides cambium. Would this be ok?

@Lonecrowe
Lonecrowe Mar 24, 2016

Yes thats perfect idea.

@Lonecrowe

Cambium is a better overall description for all their products. They sort of dropped the canopy name for a lot of the newer products.

@pheinrichs pheinrichs Split Cambium/Canopy Detection and Polling
985e1a4
@laf
Member
laf commented Mar 26, 2016

trigger ci

@laf laf merged commit a9b50a4 into librenms:master Mar 29, 2016

2 checks passed

Scrutinizer 101 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf added the New-Device label Mar 29, 2016
@pheinrichs pheinrichs deleted the pheinrichs:issue-3277 branch Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment