New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Cambium Support #3279
Added Cambium Support #3279
Conversation
@@ -1363,7 +1363,7 @@ | |||
$config['os'][$os]['icon'] = 'hikvision'; | |||
|
|||
// Canopy / Cambium support | |||
$os = 'canopy'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless canopy isn't valid then I'd have thought this needs to stay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canopy is only labeled for the FSK and 450 equipment. When it came to the ptp 650/250 or the epmp equipment they wouldn't be considered canopy so it seemed more appropriate to generalize them all as cambium. The same detection that was being used for those canopy is still in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in mind $os is for naming the OS that a device runs not the company or product range. So for cisco we have ios, iosxe, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, in that sense. It would be divided into 2 OS's if this is okay.
Canopy OS:
Cambium fsk,450 SM/AP
Cambium OS:
PTP650
PTP250
ePTP
Those devices under the cambium don't have any OS that i can really label them besides cambium. Would this be ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thats perfect idea.
Cambium is a better overall description for all their products. They sort of dropped the canopy name for a lot of the newer products. |
trigger ci |
Added Cambium Support with multiple custom graphs
New Supported devices
Also added signal sensor, and setup sensor for these devices