Added config option:
to set limit for typeahead results. Default is set to 5 (as default was before).
add config option for typeahead limit
Whilst the config name isn't right, this PR introduced a config option you can use: #2957
If not, then this will still need to be updated to be a db config option.
Auto-Deploy finished, Test PR at http://3363.ci.librenms.org or https://3363.ci.librenms.org
Ah, I missed that PR. It is two different things however, though related so both need to be adjusted. The one in librenms/librenms#2957 controls how many results are fetched from the db, and the typeahead config in this PR controls how many of these results that are actually shown.
So even if you set the webui setting for max search limit to '20', you're still only going to see 5 typeahead results without this setting.
My suggestion would be that the
configuration option is used to set the typeahead limit as well (thereby scrapping the "config['typeahead_limit']" option suggested at first in this PR). That should be the desired result, or am I missing some usecase?
Unless I'm missing something then surely saying I want to see 20 db results translates to I want to see 20 search results so we can re-use the config option?
use existings webui option (global_search_result_limit) to set typeah…
…ead limit instead of introducing new config option
Merge branch 'master' of https://github.com:/wiad/librenms into issue…
forgot setting typeahead_limit option for dash