Added CPU temperature discovery/polling for DNOS #3395

Merged
merged 4 commits into from Apr 22, 2016

Projects

None yet

4 participants

@cschoonover91
Contributor

Issue #3394

@cschoonover91 cschoonover91 Added CPU temperature discovery/polling for DNOS
e866cde
@laf
Member
laf commented Apr 20, 2016

Looks like the polling file is the same as the discovery file :)

@laf laf added the Blocker label Apr 20, 2016
cschoonover91 added some commits Apr 20, 2016
@cschoonover91 cschoonover91 Removed includes/polling/temperatures/dnos.inc.php - polling script a…
…ppears unnecessary
6bdb8fc
@cschoonover91 cschoonover91 Merge branch 'master' of github.com:/cschoonover91/librenms into issu…
…e-3394
2131774
@cschoonover91
Contributor

I'm going to try and rewrite the poller

@cschoonover91 cschoonover91 Merge branch 'master' of github.com:/cschoonover91/librenms into issu…
…e-3394
f837e5b
@cschoonover91
Contributor

I apparently misunderstood sensor polling entirely. Looks like a new polling script is unnecessary, even for stacked switches. The single file 'includes/discovery/sensors/temperatures/dnos.inc.php' plus the existing sensor polling successfully adds temperature data to DNOS devices.

@murrant
Contributor
murrant commented Apr 21, 2016

Yeah, there is a generic poller for most health sensors that does the right thing.

@laf laf removed the Blocker label Apr 22, 2016
@laf laf merged commit 3bf0ad1 into librenms:master Apr 22, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment