Add support for stopping devices being added with duplicate sysNames #3473

Merged
merged 1 commit into from May 10, 2016

Projects

None yet

4 participants

@laf
Member
laf commented May 2, 2016 edited

I've left this enabled for now but we should consider changing this to false so that duplicate devices based on sysName aren't added.

I've also updated the addhost output so that an error is printed and not the help details as it's confusing. This could do with expanding further but it's a quick fix.

Fix #3012

@laf laf Add support for stopping devices being added with duplicate sysNames
8a46c76
@laf laf added the Core label May 2, 2016
@murrant
Contributor
murrant commented May 4, 2016 edited

Seems fine, if we do set it false, then we need to have a clear explanation of why librenms thinks the device exists on the add device web page as well.

@laf
Member
laf commented May 4, 2016

Unfortunately the addHost / createHost don't currently return anything other than true/false so nothing more than a generic failed message can be done at this time.

@f0o
Member
f0o commented May 5, 2016

👍

@laf
Member
laf commented May 7, 2016

bump

@laf
Member
laf commented May 10, 2016

bump

@murrant murrant merged commit 84acb30 into librenms:master May 10, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-3012 branch May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment