Added ability to show Services on Availability Map #3496

Merged
merged 5 commits into from May 4, 2016

Projects

None yet

3 participants

@BeryJu
Contributor
BeryJu commented May 4, 2016

In the Settings you can choose between 'Only Devices' (Default), 'Only Services' and 'Devices and Services'.

@BeryJu BeryJu Added ability to show Services on Availability Map
In the Settings you can choose between 'Only Devices' (Default), 'Only Services' and 'Devices and Services'.
4320116
@BeryJu BeryJu Fixed availability-map.inc.php's Service Links
Links were pointing to the wrong destination.
723bf03
@laf
Member
laf commented May 4, 2016 edited

Need to change <div class="col-sm-4"> to something like <div class="col-sm-8"> otherwise the dropdown doesn't fit well.

@laf laf added the WebUI label May 4, 2016
@BeryJu BeryJu Fixed availability-map.inc.php dropdown
ab89052
@laf
Member
laf commented May 4, 2016

Sorry, last thing before merging.

We have docs on code formatting standards, you'll want to have a read. However you've change things like

}
else {

to } else {

Can you switch back pls.

@BeryJu BeryJu Fixed availability-map.inc.php to follow guidelines
6c20534
@laf
Member
laf commented May 4, 2016

Looks like you've switched <div class="col-sm-4"> back in on that last commit :(

@BeryJu BeryJu Final fix to availability-map.inc.php
25ec063
@laf laf merged commit 580558d into librenms:master May 4, 2016

3 checks passed

Auto-Deploy Build finished. No test results found.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment