Rename $ds to $ldap_connection #3596

Merged
merged 2 commits into from Jun 4, 2016

Projects

None yet

2 participants

@murrant
Contributor
murrant commented Jun 3, 2016

$ds is a global variable, there are many name collisions in the code. Rename it to avoid the collisions.

Fixes: #3532
May fix issues users have seen with getting logged out...

@murrant murrant Rename $ds to $ldap_connection
$ds is a global variable, there are many name collisions in the code.  Rename it to avoid the collisions.
9b0bd4c
@murrant murrant added the Bug label Jun 3, 2016
@laf laf added the Blocker label Jun 3, 2016
@laf
Member
laf commented Jun 3, 2016

Think we have $ds in the last three changed files, change start from around line 100 when the connection is done at the top.

@murrant
Contributor
murrant commented Jun 4, 2016 edited

@laf Oh my, silly me to miss that. And I only tested active_directory because that is what I have.

Double checked this time ;) Thanks.

@laf laf removed the Blocker label Jun 4, 2016
@laf laf merged commit cfdbc6f into librenms:master Jun 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:ds-var-fix branch Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment