Added ability to search graylog using the resolved IP we now store #3697

Merged
merged 2 commits into from Jun 22, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Jun 21, 2016

Fix #1911

Tested on my install (I don't need the IP query to look up my devices) and it doesn't break but I can't guarantee that it does actually work :)

@laf laf Added ability to search graylog using the resolved IP we now store
744e3d5
@laf laf added the WebUI label Jun 21, 2016
@murrant murrant and 2 others commented on an outdated diff Jun 21, 2016
html/includes/table/graylog.inc.php
$query .= 'source:"'.$filter_hostname.'" || source:"'.$ip.'"';
+ if (isset($device['ip'])) {
@murrant
murrant Jun 21, 2016 Contributor

Would it be worth adding a check that $ip != $device['ip'] before adding the additional parameter?

@f0o
f0o Jun 22, 2016 Member

It would be prettier, I agree

@laf
laf Jun 22, 2016 Member

Updated, thanks.

@laf laf Updated if check for device ip
067f0f8
@murrant murrant merged commit 47afbd5 into librenms:master Jun 22, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-1911 branch Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment