Cisco SB SG220 Fix #3705

Merged
merged 2 commits into from Jun 24, 2016

Projects

None yet

3 participants

@Rosiak
Contributor
Rosiak commented Jun 22, 2016

#3529

Looks like there not much else to pull from these..

Søren Rosiak Cisco SB SG220 Fix
82cf34e
@laf laf commented on an outdated diff Jun 22, 2016
includes/polling/os/ciscosb.inc.php
@@ -13,3 +13,7 @@
$hardware = str_replace(' ', '', snmp_get($device, 'CISCOSB-Physicaldescription-MIB::rlPhdUnitGenParamModelName.1', '-Ovq'));
$serial = snmp_get($device, 'CISCOSB-Physicaldescription-MIB::rlPhdUnitGenParamSerialNum.1', '-Ovq');
$features = snmp_get($device, 'CISCOSB-Physicaldescription-MIB::rlPhdUnitGenParamServiceTag.1', '-Ovq');
+
+if ($poll_device['sysObjectID'] == '.1.3.6.1.4.1.9.6.1.89.26.1') {
@laf
laf Jun 22, 2016 Member

Might seem silly on this one but it's worth moving that above the current hardware and doing an else so we avoid an snmp_get request for no reason if it's not needed / used.

Søren Rosiak Small change.
5262bb0
@laf laf added the New-Device label Jun 24, 2016
@laf laf merged commit 75a2a66 into librenms:master Jun 24, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Rosiak Rosiak deleted the Rosiak:issue-3529 branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment