Follow-up to #3597
It was found that the first PR caused a change in behavior when using the default $config of LibreNMS, where the values for transit_descr, peering_descr, etc, are empty strings. The main branch always searches for $type in '$type_descr' regardless of $config, but my branch ignored that value if there was something set in $config. Since those values are configured but blank by default, my branch wouldn't return the same set of interfaces.
To fix this, there's an extra commit here that changes the default value for each description type to the name of the type itself. This makes my branch consistent with the main branch with the default config.
Auto-Deploy finished, Test PR at http://3722.ci.librenms.org or https://3722.ci.librenms.org
Works fine for me although it needs a rebase :(
adding name to authors and signing contributors agreement
I agree to the conditions of the Contributor Agreement
contained in doc/General/Contributing.md.
create common method for generating type_wheres
giving graph widgets option to manually specify port type
matching default port description types with their names