Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
deduping type_where code, adding manual types to graph widgets, updating default descriptions #3722
Follow-up to #3597
It was found that the first PR caused a change in behavior when using the default $config of LibreNMS, where the values for transit_descr, peering_descr, etc, are empty strings. The main branch always searches for $type in '$type_descr' regardless of $config, but my branch ignored that value if there was something set in $config. Since those values are configured but blank by default, my branch wouldn't return the same set of interfaces.
To fix this, there's an extra commit here that changes the default value for each description type to the name of the type itself. This makes my branch consistent with the main branch with the default config.