thecityofguanyu/add telco systems os #3773

Merged
merged 9 commits into from Jul 6, 2016

Projects

None yet

3 participants

@thecityofguanyu
Contributor

Add support for Telco Systems BiNOS and BiNOX OSs, including copious MIB files.

walrus and others added some commits Jul 2, 2016
walrus add files to telco-systems branch 6236657
walrus * Split Telco Systems discovery into BiNOX and BiNOS
 * Fix formatting errors

 Changes to be committed:
	renamed:    includes/discovery/mempools/batm.inc.php -> includes/discovery/mempools/binox.inc.php
	renamed:    includes/discovery/os/batm.inc.php -> includes/discovery/os/binos.inc.php
	new file:   includes/discovery/os/binox.inc.php
	deleted:    includes/discovery/processors/batm.inc.php
	new file:   includes/discovery/processors/binos.inc.php
	new file:   includes/discovery/processors/binox.inc.php
	deleted:    includes/discovery/sensors/temperatures/batm.inc.php
	new file:   includes/discovery/sensors/temperatures/binos.inc.php
	new file:   includes/discovery/sensors/temperatures/binox.inc.php
	renamed:    includes/polling/mempools/batm.inc.php -> includes/polling/mempools/binox.inc.php
	new file:   includes/polling/os/binos.inc.php
	renamed:    includes/polling/os/batm.inc.php -> includes/polling/os/binox.inc.php
6763ad0
walrus * Renamed MIB directories to differentiate between BiNOS and BiNOX M…
…IB files
1be5995
Chris A. Evans Merge remote-tracking branch 'origin/master' into thecityofguanyu/add…
…-telco-systems-os
9a3cf96
Chris A. Evans updated definitions.inc.php to include telco systems binos and binox os: 7850f9e
Chris A. Evans added telco systems icon, updated definitions to reference said icon a012d7e
Chris A. Evans fixed typo in binox temperature sensor discovery module
875e6f9
@laf
Member
laf commented Jul 5, 2016

I can see quite a few of these mibs are standard ones of ours. Unless you actively use the mibs I'd remove them imho.

Chris A. Evans fixed typo in: includes/discovery/sensors/temperatures/binos.inc.php
        removed all mibs, as they are not actually referenced in modules
95ad8f1
@thecityofguanyu
Contributor

@laf

I can see quite a few of these mibs are standard ones of ours. Unless you actively use the mibs I'd remove them imho.

Removed the MIBs.

Also fixed a line in includes/discovery/sensors/temperatures/binos.inc.php

@laf
Member
laf commented Jul 5, 2016

You've got some blank } else {, any reason why:

+    else {
 +
 +    }
@laf laf added the New-Device label Jul 5, 2016
Chris A. Evans removed empty/unsued else conditionals
38e222f
@thecityofguanyu
Contributor

@laf

You've got some blank } else {, any reason why:

This was originally built as one OS rather than two, so that's probably where those came from. I must have just missed those empty elses when cleaning up after splitting into two OSs.

This is fixed.

@laf laf merged commit fa366b5 into librenms:master Jul 6, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thecityofguanyu thecityofguanyu deleted the thecityofguanyu:thecityofguanyu/add-telco-systems-os branch Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment