Add date to git version info #3782

Merged
merged 2 commits into from Jul 7, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Jul 6, 2016

valdiate: local tz, rfc2822
poller: iso 8601
about: iso 8601 -> browser local
Also, do not fetch github info on about page, it isn't used.

Fixes: #3775

@murrant murrant Add date to git version info
valdiate: local tz, rfc2822
poller: iso 8601
about: iso 8601 -> browser local
Also, do not fetch github info on about page, it isn't used.
846c5ab
@Rosiak
Contributor
Rosiak commented Jul 6, 2016

👍

@laf
Member
laf commented Jul 6, 2016
Version info:
PHP Fatal error:  Uncaught exception 'Exception' with message 'DateTime::__construct(): Failed to parse time string (%cI) at position 0 (%): Unexpected character' in /opt/librenms/validate.php:79
Stack trace:
#0 /opt/librenms/validate.php(79): DateTime->__construct('%cI')
#1 {main}
  thrown in /opt/librenms/validate.php on line 79
@laf
Member
laf commented Jul 6, 2016
git show --pretty='%H|%cI' -s HEAD
846c5ab0c9b8b098f56e91df41a819ecefb51fc5|%cI
git version 1.8.3.1
@murrant
Contributor
murrant commented Jul 6, 2016

Dang, I'll come up with something for old versions of git. Thanks @laf

@murrant murrant Support older versions of git
8362039
@laf laf added the Core label Jul 7, 2016
@laf laf merged commit 0f5cfb5 into librenms:master Jul 7, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:git-date branch Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment