Component Update - Status #3821

Merged
merged 4 commits into from Jul 25, 2016

Projects

None yet

3 participants

@adaniels21487
Contributor

This PR is to implement point 1 of #3272.

Component Status
Fix up the component status field to align with Nagios status
NOTE: This will break any alerting rules that currently exist but the only code in master that sets the status field is the Cisco-OTV module.

  • Align the component status field with the Nagios standard
    0=ok, 1=warning, 2=critical
  • Modify existing modules to report these status' (Cisco-OTV)
  • Add/Modify Alerting Macros to use these status'
  • Add the a component status widget
  • Update edit page to report these status'
  • Updated status in OTV display
@adaniels21487 adaniels21487 Component Update - Status
- Align the component status field with the Nagios standard
  0=ok, 1=warning, 2=critical
- Modify existing modules to report these status' (Cisco-OTV)
- Add/Modify Alerting Macros to use these status'
- Add the a component status widget
- update edit page to report these status'
52455e1
@laf
Member
laf commented Jul 13, 2016

For some reason 122.sql has been renamed to 124.sql, you'll need to revert that as we can't change the order of the files.

I think we will also need to warn users of this change due to the impact in alerts (no matter how small the user base of that might be). If you submit a pull request to add a new entry to: https://github.com/librenms/librenms.github.io/blob/master/notifications.rss

Set the date as being +7 days from the day you do the pull request to say that we are merging this change in on that particular date and if you use alert rules which make use of components that you should disable these until after the update and edit your rule.

@adaniels21487
Contributor

Thanks @laf
Will do.

@adaniels21487 adaniels21487 - Moved SQL for upstream changes.
1d579e8
@laf
Member
laf commented Jul 18, 2016

Thanks @adaniels21487

This will need a rebase (sql file I expect). It may be worth leaving it until the day before the merge to rebase though to save having to do it again.

FOR ANYONE ELSE

Please DO NOT merge this until 25th July.

@adaniels21487 adaniels21487 - Moved SQL for upstream changes
4c0c560
@laf laf merged commit 42a8c27 into librenms:master Jul 25, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf removed the Blocker label Jul 25, 2016
@adaniels21487 adaniels21487 deleted the adaniels21487:issue-3272-1 branch Jul 25, 2016
@adaniels21487 adaniels21487 restored the adaniels21487:issue-3272-1 branch Aug 3, 2016
@adaniels21487 adaniels21487 deleted the adaniels21487:issue-3272-1 branch Aug 3, 2016
@adaniels21487 adaniels21487 restored the adaniels21487:issue-3272-1 branch Jan 18, 2017
@adaniels21487 adaniels21487 deleted the adaniels21487:issue-3272-1 branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment