Remove agent scripts #3865

Merged
merged 1 commit into from Jul 28, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Jul 22, 2016

Leave a note that they have been moved to https://github.com/librenms/librenms-agent
The goal is to prevent divergence.

@murrant murrant Remove agent scripts
Leave a note that they have been moved to https://github.com/librenms/librenms-agent
The goal is to prevent divergence.
6119aa9
@f0o
Member
f0o commented Jul 22, 2016

We should use submodules like we planned to a long time ago haha

@f0o
Member
f0o commented Jul 22, 2016

(same applies for mibs)

@laf
Member
laf commented Jul 23, 2016

Doesn't this need additional commands to be run after to get the files?

Checking this branch out results in no files in scripts/agent.

My opinion, especially for this is we should just have the README pointing people to the agent repo. Most of the time these scripts aren't going to be used on the LibreNMS box direct.

@murrant
Contributor
murrant commented Jul 24, 2016

The scripts are in daily.sh already.
But that seems valid to me and simpler. I can revert the last commit.

@laf
Member
laf commented Jul 24, 2016

I'd be interested in what the rest of @librenms/reviewers think.

Keep in mind that the scripts directory will then only get populated the day after an initial install unless we also update install docs to get people to run daily.sh manually on install time.

@laf
Member
laf commented Jul 26, 2016

@librenms/reviewers bump otherwise merging in 48 hours.

@laf laf merged commit ec3520e into librenms:master Jul 28, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:remove-agent-scripts branch Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment