Updated version_info to output unix timestamp #3914

Merged
merged 2 commits into from Aug 1, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Jul 31, 2016

Fixes a bug in Safari where it wouldn't show the date of the commit.

@laf laf Updated version_info to output unix timestamp
b35321c
@laf laf added Bug WebUI labels Jul 31, 2016
@paulgear
Member

👍 from me, but I don't use Safari at all, so will leave this for someone else to merge after testing.

@murrant murrant and 1 other commented on an outdated diff Jul 31, 2016
html/pages/about.inc.php
@@ -237,5 +237,5 @@
// convert the version date from ISO 8601 to the browser's timezone
@murrant
murrant Jul 31, 2016 Contributor

Can you update the comment?

Looks like I wasn't using moment.js :-/

@laf
laf Jul 31, 2016 Member

Done.

Wouldn't have mattered using moment, they fall back to new Date anyway.

@laf laf Removed comment
7d72cf0
@murrant murrant merged commit 81bea7d into librenms:master Aug 1, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:safari-date branch Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment