Updates to Dell Equallogic storage disco/poll #3956

Merged
merged 5 commits into from Aug 5, 2016

Projects

None yet

3 participants

@ahmedsajid
Contributor
ahmedsajid commented Aug 4, 2016 edited

Please note

Please read this information carefully.

[X] Have you signed the Contributors agreement

[X] Have you followed our code guidelines?

Detect Equalogics as storage device.
The units need to be set to 1000000 since the returned storage values are in MBs.

ahmedsajid added some commits Jul 28, 2016
@ahmedsajid ahmedsajid Merge pull request #12 from librenms/master
Updating fork
beb5362
@ahmedsajid ahmedsajid Equalogic patches
Detect Equalogics as storage device.

The units need to be set to 1000000 since the returned storage values are in MBs.
e62f4dc
@laf laf commented on an outdated diff Aug 4, 2016
includes/definitions.inc.php
@@ -1048,6 +1048,7 @@
$os = 'equallogic';
$config['os'][$os]['text'] = 'Dell EqualLogic';
+$config['os'][$os]['type'] = 'storage';
@laf
laf Aug 4, 2016 Member

Just needs formatting better to move it in line with others.

@laf laf commented on the diff Aug 4, 2016
includes/discovery/storage/eql-storage.inc.php
@@ -19,7 +19,7 @@
foreach ($eql_storage as $index => $storage) {
$fstype = $storage['eqliscsiVolumeAdminStatus'];
$descr = $storage['eqliscsiVolumeName'];
- $units = 1;
+ $units = 1000000;
@laf
laf Aug 4, 2016 Member

I'm always worried about changing things like that in that it can vary from firmware to firmware. Have you confirmed this actually needs changing full stop?

@ahmedsajid ahmedsajid Update definitions.inc.php
Fixed formatting.
4ca32c0
ahmedsajid added some commits Aug 4, 2016
@ahmedsajid ahmedsajid Update definitions.inc.php
b8fa30b
@ahmedsajid ahmedsajid Update definitions.inc.php
323bb19
@ahmedsajid
Contributor
ahmedsajid commented Aug 4, 2016 edited

@laf seems to be the case for all firmwares.

From https://github.com/librenms/librenms/blob/master/mibs/equallogic/eqlvolume.mib#L381-L389:

eqliscsiVolumeSize OBJECT-TYPE
SYNTAX Integer32
MAX-ACCESS read-create
STATUS current
DESCRIPTION "This field specifies the volume size in MB. There is no default.
Note: Volume size is round to a multiple of 15MB. For thin provisioned volumes
this value represents the advertized size of the volume and
eqliscsiVolumeMinThinReserve represents the actual reserved size."
::= { eqliscsiVolumeEntry 8 }

@laf laf changed the title from Eql patches to Updates to Dell Equallogic storage disco/poll Aug 5, 2016
@laf laf removed the Blocker label Aug 5, 2016
@laf laf merged commit d0188d8 into librenms:master Aug 5, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ahmedsajid ahmedsajid deleted the ahmedsajid:eql-patches branch Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment