Added support for Dell Powerconnect 8024F CPUs #3966

Merged
merged 10 commits into from Aug 5, 2016

Projects

None yet

3 participants

@ahmedsajid
Contributor

Please note

Please read this information carefully.

[X] Have you signed the Contributors agreement

[X] Have you followed our code guidelines?

ahmedsajid added some commits Jul 28, 2016
@ahmedsajid ahmedsajid Merge pull request #12 from librenms/master
Updating fork
beb5362
@ahmedsajid ahmedsajid Merge pull request #13 from librenms/master
Updating fork
3125a81
@ahmedsajid ahmedsajid Merge pull request #14 from librenms/master
Updating fork
1e53ad0
@ahmedsajid ahmedsajid Powerconnect patches
Added CPU polling for Dell Powerconnect 8024F device. Also added cpu and memory graphs to definitions file
ec9321e
@ahmedsajid ahmedsajid Updated Powerconnect CPU
Change case statements to if else
afb0e20
@ahmedsajid ahmedsajid Changed tab to 4 spaces 854b30e
@ahmedsajid ahmedsajid Changed tab to 4 spaces
dfc6d21
@ahmedsajid ahmedsajid Removed unnecessary trimming
8f05fea
@laf laf commented on an outdated diff Aug 5, 2016
includes/discovery/processors/powerconnect.inc.php
if ($device['os'] == 'powerconnect') {
- $sysObjectId = snmp_get($device, 'SNMPv2-MIB::sysObjectID.0', '-Ovqn');
- switch ($sysObjectId) {
- case '.1.3.6.1.4.1.674.10895.3031':
- /*
- * Devices supported:
- * Dell Powerconnect 55xx
- */
+ if (strpos($device["sysObjectID"], "enterprises.674.10895.3031") !== false) {
+ echo "Dell Powerconnect 55xx";
@laf
laf Aug 5, 2016 Member

All of these echo's should be d_echo, normal output should be minimal.

ahmedsajid added some commits Aug 5, 2016
@ahmedsajid ahmedsajid Update powerconnect.inc.php
Changed echos to d_echos
2ed9d46
@ahmedsajid ahmedsajid Update powerconnect.inc.php
Changed echos to d_echos
c678c10
@laf laf merged commit 38cafef into librenms:master Aug 5, 2016

0 of 2 checks passed

Auto-Deploy Building
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ahmedsajid ahmedsajid deleted the ahmedsajid:powerconnect-patches branch Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment