Adding support for Brocade NOS sensors (Temperature and fanspeed) #3969

Merged
merged 8 commits into from Aug 10, 2016

Projects

None yet

3 participants

@Linutux42
Contributor
Linutux42 commented Aug 5, 2016 edited

Please note

Please read this information carefully.

[x] Have you signed the Contributors agreement

[x] Have you followed our code guidelines?

Maxence POULAIN and others added some commits Aug 5, 2016
Maxence POULAIN Adding support for Brocade VDX sensors 0eff696
@Linutux42 Linutux42 Merge pull request #1 from BSONetwork/brocade-vdx-sensors
Adding support for Brocade VDX sensors
5e4df9c
Maxence POULAIN and others added some commits Aug 5, 2016
Maxence POULAIN Update the current value when discovering the Brocade NOS sensors d1f790f
@Linutux42 Linutux42 Merge pull request #2 from BSONetwork/brocade-vdx-sensors
Update the current value when discovering the Brocade NOS sensors
9547a60
@laf
Member
laf commented Aug 5, 2016

When you created this pull request a template was there for you to complete, please do so.

Maxence POULAIN Updates to match the librenms coding guidelines
1d4db3d
Maxence POULAIN added some commits Aug 5, 2016
Maxence POULAIN I agree to the conditions of the Contributor Agreement
contained in doc/General/Contributing.md.
3f72a49
Maxence POULAIN Updates to add the copyright headers
51e0e6c
@laf
Member
laf commented Aug 5, 2016

Needs a rebase.

Out of interest, how much other data is in the tree: 1.3.6.1.4.1.1588.2.1.1.1.1.22.1.?

@Linutux42
Contributor
Linutux42 commented Aug 8, 2016 edited

Hi laf,

What rebase do you want me to do about the code ?

And the only other sensor in this tree is the power supply, which I planned to implement later.
http://www.fujitsu.com/downloads/STRSYS/switch/nos-601-mibref.pdf
Page 31

@laf
Member
laf commented Aug 8, 2016

You need to rebase this branch as files have changed in upstream master to cause conflicts.

If their is only one other value in the tree then I'd probably say you should walk the root of that oid and then grab what you need rather than having to run 3 snmp queries - or at least benchmark to see which is quicker.

@Linutux42
Contributor

Ok I will rebase the branch.

After reading again the doc from Brocade, I can not implement the power state because the returned value is "unknown" from brocade ...
I will update the code and use the snmpwalk cache.

Thank you,

Maxence POULAIN Fixing AUTHORS.md conflict
35d7456
@laf laf removed the Blocker label Aug 10, 2016
@laf laf merged commit 2424c26 into librenms:master Aug 10, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment