CEF Display Update #3978

merged 3 commits into from Oct 11, 2016


None yet

5 participants

Rosiak commented Aug 5, 2016

Got annoyed by the old page, just a new basic page.

Please note

Please read this information carefully.

[X] Have you signed the Contributors agreement

[X] Have you followed our code guidelines?

Initial Commit

@Rosiak Rosiak CEF Display Update
Initial Commit
@laf laf added the WebUI label Aug 5, 2016
@laf laf commented on an outdated diff Aug 5, 2016
+ <thead>
+ <tr>
+ <th>&nbsp;</th>
+ <th>Device</th>
+ <th>Entity</th>
+ <th>AFI</th>
+ <th>Path</th>
+ <th>Drop</th>
+ <th>Punt</th>
+ <th>Punt2Host</th>
+ </tr>
+ </thead>';
+foreach (dbFetchRows('SELECT * FROM `cef_switching` ORDER BY `device_id`, `entPhysicalIndex`, `afi`, `cef_index`') as $cef) {
+ $device = device_by_id_cache($cef['device_id']);
+ $entity = dbFetchRow('SELECT `entPhysicalName`, `entPhysicalModelName`, `entPhysicalContainedIn` FROM `entPhysical` WHERE `device_id` = ? AND `entPhysicalIndex` = ?', array($device['device_id'], $cef['entPhysicalIndex']));
laf Aug 5, 2016 Member

You could combine this with the previous query and do a LEFT JOIN

laf commented Aug 5, 2016

Definitely all for replacing the crap that was there before - however, I'm personally reluctant to introduce another un-paginated page.


Rosiak commented Aug 7, 2016

@laf I'll see if I can get it done during the week.

laf commented Aug 17, 2016

If you can update the sql query I'll merge this but please please submit another PR to paginate the table.

f0o commented Aug 18, 2016

👍 finally getting rid of that useless gif.

I share laf's opinion on non-paginated pages

Rosiak commented Aug 18, 2016

No worries, I'll redo it when I have some time

@Rosiak Rosiak added the Blocker label Aug 18, 2016
@Rosiak Rosiak Rebased
@Rosiak Rosiak convert sql query

The inspection completed: 2 new issues

@laf laf removed the Blocker label Oct 11, 2016
@laf laf merged commit 0bb7bfd into librenms:master Oct 11, 2016

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed
@worton worton added a commit to worton/librenms that referenced this pull request Oct 11, 2016
@Rosiak @worton Rosiak + worton feature: Added CEF Display page (#3978) fa807e3
@Rosiak Rosiak deleted the Rosiak:fix-cef-page branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment