addHost: Use Exceptions #3997

Merged
merged 4 commits into from Aug 8, 2016

Projects

None yet

3 participants

@murrant
Contributor
murrant commented Aug 7, 2016

Please note

Please read this information carefully.

[x] Have you signed the Contributors agreement

[x] Have you followed our code guidelines?

Use exceptions for addHost()
Gets rid of silly mixed return and only returns the device_id. Throwing an exception if we run into any issues.
Slightly modifies api add host output again to include device_id

@murrant murrant Use Exceptions
Use exceptions for addHost()
Gets rid of silly mixed return and only returns the device_id.  Throwing an exception if we run into any issues.
Slightly modifies api add host output again to include device_id
f3fc6f2
@murrant murrant Update docs
1482e6e
@murrant murrant changed the title from Use Exceptions to addHost: Use Exceptions Aug 8, 2016
@murrant murrant added the Blocker label Aug 8, 2016
@murrant murrant Merge remote-tracking branch 'upstream/master' into exceptions
322b79f
@murrant murrant Actually add the exceptions
5643d37
@murrant murrant removed the Blocker label Aug 8, 2016
@laf laf added the Core label Aug 8, 2016
@laf laf merged commit b93a060 into librenms:master Aug 8, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:exceptions branch Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment