rewrite of availability-map #4043

Merged
merged 7 commits into from Aug 17, 2016

Projects

None yet

5 participants

@crcro
Contributor
crcro commented Aug 12, 2016

new look and added the missing functionality

am-directpage

am-widget

@crcro crcro rewrite of availability-map
6553630
@laf laf added the Blocker label Aug 12, 2016
@laf
Member
laf commented Aug 12, 2016

Will comment a little later but looks good :)

@crcro crcro added linux os distro icon, fixed formatting
e575271
@laf laf added the WebUI label Aug 13, 2016
@laf
Member
laf commented Aug 13, 2016

This is ace :) At first I thought the replacement for the small red/green tiles wouldn't work as it was originally designed to be condensed but I like it.

Few design elements to fix, drop down is close to the text:

image

This needs to be in a table or at least formatted differently:

image

It's difficult to read the white text on the orange background in the full availability map.

light.css is only one of the themes, you need to also update dark.css and mono.css.

I'm not sure I like placing each of the html lines on a new line with $output[]. It makes it harder to read and should be as it was before.

You've also got some bad formatting on the if statements, if(something) { it should be if (something) { - notice the space.

I've not checked through much more of the code yet.

crcro added some commits Aug 13, 2016
@crcro crcro -fixed select position/size
-extra style for text on labels for readibility
-PSR-2 style
-added classes for all styles
ccc8891
@crcro crcro spacing fixes for css files
50cf4f1
@crcro crcro looks like services can have warning also, changed the warning labels…
… to warn for readability
889c02d
@crcro crcro forgot about widget host warning
1270028
@crcro
Contributor
crcro commented Aug 14, 2016

@laf could you try it again and tell me if everything is ok? (i think i fixed display issues for safari)

@laf
Member
laf commented Aug 14, 2016

Certainly better for the boxes :)

I'd say the drop down is a bit crazy in size now though:

image

I still think this seems a bit odd:

image

Maybe put the numbers in the relevant boxes?

I still think you doing $common_output[] = '<form class="form-horizontal" onsubmit="return widget_settings(this)">'; is wrong and over the top. It's duplicating so much and losing readability.

@crcro crcro rewrite code for less repetition, removed unused css classes
a4234a0
@crcro
Contributor
crcro commented Aug 14, 2016

hope this commit will be better @laf :)

@murrant
Contributor
murrant commented Aug 16, 2016

How about something like this for the counts?

http://codepen.io/anon/pen/vKPgvd

image

@crcro
Contributor
crcro commented Aug 16, 2016

this looks like v2 styling? :)

@murrant
Contributor
murrant commented Aug 16, 2016

Just bootstrap, but I would like to import this into v2. Feel free to submit a v2 PRπŸ˜€

@crcro
Contributor
crcro commented Aug 16, 2016

i'm thinking about v2, still getting used to laravel's style :(

@laf laf removed the Blocker label Aug 17, 2016
@laf laf merged commit 73ff21f into librenms:master Aug 17, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitalisator
Contributor
vitalisator commented Aug 18, 2016 edited

this brokes some settings in availability-map widget for me

  • boxes are not scalable more (if you have over 160 devices it took too much place)
  • widget settings are broken(Tile width and Show). It seems that setting from availability page are used instead.
@crcro crcro deleted the unknown repository branch Aug 18, 2016
@laf
Member
laf commented Aug 18, 2016

The pull request is probably not the place to raise this, please open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment