Added ability to force devices to use ifEntry instead of ifXEntry #4100

Merged
merged 1 commit into from Sep 2, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Aug 17, 2016 edited

Please note

Please read this information carefully.

Fix #4025

Not sure if this is the best approach to take here but basically some devices don't always output the info we need in ifXEntry for various interfaces so it's difficult for us to check we have complete data. Falling back to ifEntry seems the best approach for those devices.

The alternative would be to poll both ifXEntry and ifEntry as we did before but that would slow polling down for these devices.

@laf laf Added ability to force devices to use ifEntry instead of ifXEntry
28108ce
@laf laf added the Polling label Aug 17, 2016
@laf
Member
laf commented Aug 26, 2016

bump

@laf
Member
laf commented Aug 29, 2016

Thoughts?

@Rosiak
Contributor
Rosiak commented Aug 29, 2016

I'm good with this.

@breeman1

Hi @laf,

I have tried this PR in my test install and it works.

@laf
Member
laf commented Aug 30, 2016

@breeman1 and you get graphs?

@breeman1

Yes I do:)

@murrant murrant merged commit 0d2c443 into librenms:master Sep 2, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@deutor deutor added a commit to deutor/librenms that referenced this pull request Sep 6, 2016
@laf @deutor laf + deutor fix: Added ability to force devices to use ifEntry instead of ifXEntry ( 0ae8ec6
@laf laf deleted the laf:issue-4025 branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment