Use namespaces for classes, take 2 #4101

Merged
merged 1 commit into from Aug 18, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Aug 18, 2016 edited

Please note

Please read this information carefully.

CollectdColor, move into it's own file, change functions to camelCase
Plugins use LibreNMS\Plugins

@murrant murrant Use namespaces for classes, take 2
CollectdColor, move into it's own file, change functions to camelCase
Plugins use LibreNMS\Plugins
f5f31e8
@murrant
Contributor
murrant commented Aug 18, 2016

I had to redo the branch. The only change is in print-menubar.php
Tested with the test plugin and Weathermap

@f0o
Member
f0o commented Aug 18, 2016

Looks fine, can't spot any issues. Will merge at work with the weathermap plugin and see what happens

@laf laf added WebUI Core labels Aug 18, 2016
@laf laf merged commit 7bdc3f4 into librenms:master Aug 18, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:namespaces branch Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment