hp 2530 series procurve/aruba detection #4119

Merged
merged 3 commits into from Aug 20, 2016

Projects

None yet

4 participants

@crcro
Contributor
crcro commented Aug 19, 2016

for issue #4089

@crcro crcro fix for issue #4089
bd14338
@crcro crcro added to arubaos
29d5b8a
@murrant murrant added the New-Device label Aug 19, 2016
@murrant
Contributor
murrant commented Aug 19, 2016

Shouldn't this be in the procurve file?

@crcro
Contributor
crcro commented Aug 19, 2016 edited

first i put it there but on hp site it is marketed as aruba ... didn't want any confusion on user side

@murrant
Contributor
murrant commented Aug 19, 2016

I looked on the site and it was labeled as both. I'm guessing it's the same situation as 3com. But I think because of the sysDescr check you have it would be good to go into the procurve file. If you were doing sysObjectID check, it might be a different story.

@crcro crcro Revert "added to arubaos"
This reverts commit 29d5b8a.
1de7619
@crcro
Contributor
crcro commented Aug 19, 2016

@murrant ... reverted back to procurve

@laf laf merged commit d7f6f0b into librenms:master Aug 20, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@crcro crcro deleted the unknown repository branch Aug 20, 2016
@Rosiak Rosiak referenced this pull request Aug 29, 2016
Merged

fix: HP 1820 Discovery #3933 #4259

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment