Freeswitch support #4203

Merged
merged 25 commits into from Aug 26, 2016

Projects

None yet

9 participants

@Tatermen
Contributor

Support for pulling statistics from freeswitch via check_mk. See librenms/librenms-agent#53 for check_mk plugin.

Please read this information carefully.

Tatermen added some commits Aug 25, 2016
@Tatermen Tatermen Added support for freeswitch via unix_agent 9ab4b82
@Tatermen Tatermen Fixed display of graphs on apps overview
0f5c178
@Tatermen Tatermen Removed tab indents
1dd2e91
@laf
Member
laf commented Aug 26, 2016

Awesome, thanks for the contribution.

I'd say it's just formatting fixes that need to be done, if you rebase against master you can run ./scripts/pre-commit.php to see what needs updating.

laf and others added some commits Aug 24, 2016
@laf @Tatermen laf Fixed not sending port_descr_type (#4188) 7d42298
@laf @Tatermen laf Removed / Updated version info to just be LibreNMS (#4193) fab5e42
@laf @Tatermen laf Remove requirement for ['enable_printers'] (#4192) bc48cac
@crcro @Tatermen crcro ricoh devices returning garbage as toner level (#4180)
* ricoh devices returning garbage as toner level

* ricoh toner extra check

* more ricoh rules
e995097
@murrant @Tatermen murrant Fix remote rrdtool_check_rrd_exists() calls (#4196)
It was comparing with the full name when rrdcached only printed out the relative name.
Thanks mikmak on irc for lots of troubleshooting.
5ab87a9
@f0o @Tatermen f0o check for no motd line (#4200)
Fixes #4199
6e4fadc
@murrant @Tatermen murrant Only push the toc down, not the content
the toc is on top when the header switches to two lines, so we only need to push that down.
f9ad689
@deutor @Tatermen deutor IRC bot - detect lost communication
Force reconnect if no data received from server for config['irc_conn_timeout'] seconds (that may happen when network/VPN goes down - in such case IRC bot won't get immediately notification that connection was lost, at least till it tries to send anything).
f6a49dd
@deutor @Tatermen deutor Update irc.php 211af11
@deutor @Tatermen deutor Update irc.php 9458a57
@deutor @Tatermen deutor Update irc.php 0d8be83
@deutor @Tatermen deutor Update irc.php 034ee40
@mmarchand @Tatermen mmarchand fix ifName randomly defined, breaking influxdb updates (#4202) 2010ab0
@deutor @Tatermen deutor IRC bot - allow to disable ssl check
In PHP 5.6.x stream wrappers verify peer certificates and host names by default when using SSL. That fix allows to turn off that verification with config option $config['irc_disable_ssl_check'] = true; 
It is useful when you want to use self generated certificate for your own IRC server.
b0c3855
@deutor @Tatermen deutor Update irc.php 37cacbd
@laf @Tatermen laf More more docs (#4197)
* Updated docs + some small code changes

* Added validating code doc for developers

* Doc updates

* Updates and improvements
012ba5e
@murrant @Tatermen murrant Add ntpd to the list of agentapps (#4194) 34f3e6e
@murrant @Tatermen murrant Fix deprecated constructors
This small change should't prevent easy updates to libraries and fixes the lint check on php7
f3f0706
@murrant @Tatermen murrant Don't allow php7 failures anymore 044f452
@murrant @Tatermen murrant Fix defunct process issues: create Proc class (#4210)
* Proc class
Encapsulate processes in a class, when they go out of scope, we can use the __destruct() process to make sure the process terminates.

* Fix rrdtool_last checks failing

* Don't close rrdtool in rrd_graph
Try to start rrdtool process if they haven't been started yet
Remove some extra debug output

* phpdocs added
several cleanups
should still be functioning the same
Only open one  rrdtool process for graph.php
13fcb9d
@murrant @Tatermen murrant include common.php in definitions.inc.php (#4198)
definitions.inc.php makes a call to dbFetchRow, which uses c_echo()
It is safe to include common.php here as it only has function definitions.
ebd4bed
@murrant @Tatermen murrant Use pre-commit.php in for travis-ci tests (#4212)
9c24145
@scrutinizer-notifier

The inspection completed: 7 new issues, 4 updated code elements

@laf laf removed the Blocker label Aug 26, 2016
@laf laf merged commit 19f231d into librenms:master Aug 26, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Tatermen
Contributor

Unfortunately I just get errors when I try to run that.

Running lint check...
success
Checking PSR-2 style... sh: ./vendor/bin/phpcs: No such file or directory
failed

Running unit tests... sh: ./vendor/bin/phpunit: No such file or directory
failed
@laf
Member
laf commented Aug 26, 2016

Sorry you need to install a few things - should have said:

https://github.com/librenms/librenms/blob/master/doc/Developing/Validating-Code.md

@Tatermen
Contributor
Tatermen commented Aug 26, 2016 edited

That worked. I know you've already merged it, but here's the results for the record:

Running lint check...
success
Checking PSR-2 style... success
Running unit tests... success
Tests ok, submit away :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment