Added service to api calls #4215

Merged
merged 9 commits into from Aug 26, 2016

Projects

None yet

4 participants

@nerdalertdk
Contributor
nerdalertdk commented Aug 26, 2016 edited

Need to get services status from the api and wanted to share it with you.

I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.

Please note

Please read this information carefully.

nerdalertdk added some commits Aug 26, 2016
@nerdalertdk nerdalertdk Get services from API
/services = list all services
/services/:hostname = get services by host
d26a1ff
@nerdalertdk nerdalertdk list_services
/services?state = filter by service state
/service?type = filter by service type
0f12c61
@nerdalertdk nerdalertdk Update AUTHORS.md 1bf6ed6
@nerdalertdk nerdalertdk use space not tabs
c873a35
nerdalertdk added some commits Aug 26, 2016
@nerdalertdk nerdalertdk tabs to spaces 4db541c
@nerdalertdk nerdalertdk tabs to spaces
feb6696
@laf
Member
laf commented Aug 26, 2016

Brilliant, thanks for contributing. Few things though before we can merge :)

If you can sign your next commit with the contributors agreement text, it needs to be in the commit message rather than just here.

You need to update the docs as well to detail the new API calls.

Some code fixes need to be done: https://scrutinizer-ci.com/g/librenms/librenms/inspections/eac19c25-a6c3-4eee-8065-01dd9ceb044e/code-structure/operation/html%2Fincludes%2Fapi_functions.inc.php%3A%3Alist_services

@laf laf added API Blocker labels Aug 26, 2016
@nerdalertdk
Contributor

I did added my self to the author file 1bf6ed6

Will update docs and code

@nerdalertdk nerdalertdk Update api_functions.inc.php
8a6ad07
@nerdalertdk nerdalertdk services docs
cd7cf30
@laf
Member
laf commented Aug 26, 2016

Thanks. The issue with contributors agreement is that you need to actually put: I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md. into a commit message in your git client. If you edit the AUTHORS.md file and put a space after your name then do:

git commit -a -m 'I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.'

nerdalertdk I agree to the conditions of the Contributor Agreement contained in d…
…oc/General/Contributing.md.
8630739
@scrutinizer-notifier

The inspection completed: 1 updated code elements

@laf laf removed the Blocker label Aug 26, 2016
@laf laf merged commit b5e1378 into librenms:master Aug 26, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf
Member
laf commented Aug 26, 2016

Awesome - thanks for contributing

image

@nerdalertdk
Contributor

Will add example to docs when i pull this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment