Add cisco wireless controller detection #422

Merged
merged 1 commit into from Feb 12, 2015

Projects

None yet

3 participants

@tuomari
tuomari commented Jan 23, 2015

No description provided.

@laf
Member
laf commented Jan 23, 2015

Hi @tuomari, many thanks for the PR's.

One of us will get to this pretty soon, in the meantime can you submit a PR following the doc: https://github.com/librenms/librenms/blob/master/doc/General/Contributing.md to confirm that you have the right to submit this code. An example PR is below if you want to look at a previous one, please note that AUTHORS.md is now in the main LibreNMS directory rather than docs:

#250

Thanks.

@laf
Member
laf commented Jan 23, 2015

One quick comment, is wlc the correct / best name for the OS description?

@tuomari
tuomari commented Jan 24, 2015

Thanks for the comments

I will post a Contributing.pm PR shortly.

Would ciscowlc be a better name? Other suggestions?

What is current practice for including MIB:s. They are convinient, but pose a licencing problem, as discussed in #28.

@laf
Member
laf commented Jan 24, 2015

Thanks for responding @tuomari.

ciscowlc seems a better fit.

For the MIB, it's fine to include them so long as they don't contain a license saying you can't. An update to that discussion has resulted in: https://github.com/librenms/librenms/blob/master/doc/General/Contributing.md

"We consider inclusion of files such as MIBs in the LibreNMS repository to be merely aggregation in a distribution medium as per the last paragraph of the GPLv3 section 5 ("Conveying Modified Source Versions"), and because they are not combined with LibreNMS to form a larger program, the GPLv3 does not apply to them. This is not a legal ruling - it is simply a statement of our intent and current interpretation."

@laf
Member
laf commented Feb 3, 2015

Hi @tuomari, any news on the update and the contributing PR so we can get this merged in.

@tuomari
tuomari commented Feb 11, 2015

Rebased against master and changed os key from "wlc" to "ciscowlc"
Also created contributing agreement PR #447

@paulgear
Member

Thanks @tuomari. Those wlc.* files will need to be renamed to ciscowlc.* in order for this to work, though. I would also suggest adding your own copyright notice to the top of them - you can see a sample in doc/General/Contributing.md.

@laf laf merged commit 498e4c3 into librenms:master Feb 12, 2015

1 check passed

Scrutinizer 4 new issues
Details
@tuomari tuomari deleted the tuomari:wlc branch Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment