fix: HP 1820 Discovery #3933 #4259

Merged
merged 3 commits into from Sep 4, 2016

Projects

None yet

5 participants

@Rosiak
Contributor
Rosiak commented Aug 29, 2016

Please note

Please read this information carefully.

  • Have you signed the Contributors agreement
  • Have you followed our code guidelines?
    Fix #3933
    Also remove coded added in #4119 as the device in question should be added as a new OS type, not procurve (arubaos or similar), and the code doesn't work on the particular device.
@Rosiak Rosiak fix: HP 1820 Discovery #3933
0041f36
@laf
Member
laf commented Aug 29, 2016

Tagging @murrant and @crcro as you both had in put in the PR mentioned.

@laf laf added the Blocker label Aug 29, 2016
@Rosiak Rosiak re-add old discovery code as @anden4380 confirms it works as intended
f22df4a
@Rosiak Rosiak removed the Blocker label Sep 2, 2016
@Rosiak
Contributor
Rosiak commented Sep 2, 2016

I re'addded the code again, as @anden4380 now confirms it works.

@murrant
Contributor
murrant commented Sep 2, 2016

Needs rebase to fix travis-ci build, thanks.

@Rosiak Rosiak Merge branch 'master' of https://github.com/librenms/librenms into is…
…sue-3933
82dd83c
@scrutinizer-notifier

The inspection completed: 3 new issues

@murrant murrant merged commit 1174954 into librenms:master Sep 4, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@deutor deutor added a commit to deutor/librenms that referenced this pull request Sep 6, 2016
@Rosiak @deutor Rosiak + deutor fix: HP 1820 Discovery #3933 (#4259)
* fix: HP 1820 Discovery #3933

* re-add old discovery code as @anden4380 confirms it works as intended
cb2a0e7
@Rosiak Rosiak deleted the Rosiak:issue-3933 branch Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment