Adding support for Lanier printers #4267

Merged
merged 3 commits into from Aug 30, 2016

Projects

None yet

5 participants

@HybridAU
Contributor

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

We have a Lanier printer which is a fairly popular brand of rebadged Ricoh printers. I've basically copied the settings from ricoh to lanier.

I've run pre-commit.php and its says Tests ok, submit away :) and the code seems to be working for us, but I'm new to php so it might be worth double checking.

HybridAU added some commits Aug 30, 2016
@HybridAU HybridAU Remove entry for 'richoh'
It looks like that's a typo and ricoh appears further down.
7e63fcf
@HybridAU HybridAU Add Lanier printers
Lanier printers are rebadged richo so I've copied the settings for ricoh
printers
e531253
@HybridAU HybridAU I agree to the conditions of the Contributor Agreement contained in d…
…oc/General/Contributing.md.
0a17f79
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf commented on the diff Aug 30, 2016
includes/definitions.inc.php
@@ -1534,13 +1543,6 @@
$config['os'][$os]['over'][0]['graph'] = 'device_toner';
$config['os'][$os]['over'][0]['text'] = 'Toner';
-$os = 'richoh';
@laf
laf Aug 30, 2016 Member

Unfortunately you've removed the richoh code here :(

If you can add this back in pls.

@crcro
crcro Aug 30, 2016 Contributor

I think that is a wrong definition?
i don't see anything related to os 'richoh' discovery ... and there is already and 'ricoh' before it

@laf
laf Aug 30, 2016 Member

You are indeed correct :)

@laf laf added Blocker New-Device and removed Blocker labels Aug 30, 2016
@laf laf merged commit 54daec3 into librenms:master Aug 30, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment