Add case insensitive string helper functions. #4283

Merged
merged 2 commits into from Aug 31, 2016

Projects

None yet

4 participants

@murrant
Contributor
murrant commented Aug 30, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Not sold on the function names here, any better suggestions?

@murrant murrant Add case insensitive string helper functions.
38901bf
@laf
Member
laf commented Aug 30, 2016

Not easier to just pass a true / false to str_contains as a 3rd param?

@murrant
Contributor
murrant commented Aug 30, 2016

laf, I thought about that but I thought it would be better to be more explicit. That would fix the silly name issue...

@laf
Member
laf commented Aug 30, 2016

It would fix the silly name issue :)

@murrant murrant Combined case sensitive and insensitive functions
Added tests
9b93fc5
@scrutinizer-notifier

The inspection completed: 7 new issues, 7 updated code elements

@laf laf merged commit f59cfa3 into librenms:master Aug 31, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf
Member
laf commented Aug 31, 2016

image

@murrant murrant deleted the murrant:string-insensitive branch Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment