Alerting Update #429

Merged
merged 5 commits into from Jan 31, 2015

Projects

None yet

2 participants

@f0o
Member
f0o commented Jan 25, 2015

Added:
Follow-Up notifications when a situation betters/worsens
Inverted Alerts
Nested Control-tags
Extended variable-scope for incidents

@f0o f0o Added:
	Follow-Up notifications when a situation betters/worsens
	Inverted Alerts
	Nested Control-tags
	Extended variable-scope for incidents
fa86e93
@f0o f0o closed this Jan 25, 2015
@f0o f0o reopened this Jan 25, 2015
@f0o
Member
f0o commented Jan 25, 2015

Re: unused code issues
$obj is used within the eval'd code. Scrut doesnt detect this.
$rep is literally used a couple of lines after the error... No clue why it reports.

Sorry for close&reopen, I misclicked on the touchscreen

@f0o
Member
f0o commented Jan 26, 2015

So i was sleeping and noticed at some point that my variable population has a bug when running something like:

{foreach %faults}
  {if %value.portName }Name: %value.portName{/if}
{/foreach}

The variable in the condition will be substituded wrong, likely to {$value['portName']} which is ok for text but not for conditionals.

I will commit a fix within the next 2 hrs probably.

@f0o
Member
f0o commented Jan 26, 2015

I got no idea why laf's commit got into this... my git seems to have rebased before push.. Apologies

@laf laf added the enhancement label Jan 27, 2015
@laf laf merged commit 836a914 into librenms:master Jan 31, 2015

1 check passed

Scrutinizer 8 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment