feature: Added new discovery-wrapper.py script to replicate poller-wrapper.py #4351

Merged
merged 2 commits into from Sep 9, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Sep 5, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Taken poller-wrapper.py and modified it to be used for discovery. This isn't enabled by default but is documented for people to use. We can see how it goes and then enable it once we've had some good feedback.

Fix #4306

@laf laf feature: Added new discovery-wrapper.py script to replicate poller-wr…
…apper.py
118786c
@laf laf added the Blocker label Sep 5, 2016
@laf
Member
laf commented Sep 5, 2016

Leave this for now, will add distributed polling support in.

@laf laf Added distributed polling support
f7ea844
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf removed the Blocker label Sep 6, 2016
@laf
Member
laf commented Sep 6, 2016

Distributed support added.

@murrant
Contributor
murrant commented Sep 8, 2016

What about combining this with the poller-wrapper.py? Or is it better having them separate?

@laf
Member
laf commented Sep 8, 2016

I guess we could but a couple of thoughts:

It could look confusing in cron and lead to people running wrapper.py poller instead of wrapper.py discovery if that's how we'd pass the arguments.

Could make debugging a little bit harder.

I think I'd vote for separate but happy to merge if people feel that's what we should do.

@murrant murrant merged commit 74483dc into librenms:master Sep 9, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-4306 branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment