Cisco Integrated Management Console #4454

Merged
merged 5 commits into from Oct 6, 2016

Projects

None yet

5 participants

@adaniels21487
Contributor
adaniels21487 commented Sep 16, 2016 edited

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Features:

  • Pulls all hardware items and stores them in entPhysical and components
  • A critical alarm is raised if a component fails
  • Creates sensors for all graphable items.

Resolves #4252

@laf
Member
laf commented Sep 16, 2016

@adaniels21487 We're following psr2 now, you'll need to resolve all of the formatting issues before we can merge.

@adaniels21487
Contributor

Thanks @laf PSR-2 issues fixed.
Now I have a couple of scrutiniser issue to look at...

@laf
Member
laf commented Sep 20, 2016

What's the purpose of the cimc poller/disco modules?

Do you have a screenshot to show the output?

I realise the functions are specific to these modules but they should be moved to includes/functions.inc.php

@adaniels21487
Contributor
adaniels21487 commented Sep 20, 2016 edited

Hi @laf
The discovery module pulls hardware information from the device.
This is displayed from components as a pane on the overview page for the device:
image
You can see an active PSU fault on this device.

And from entPhysical on the inventory tab:
image

The poller module checks the hardware status every poller cycle. This is for alerting only, graphing is handled by sensors.

And roger on the functions, I'll move them.

Thanks,
Aaron

@laf
Member
laf commented Sep 20, 2016

Does this not belong in the entity-physical disco / poller module then?

We can't keep adding poller modules for each unique item per vendor, it's going to get too complicated and cause future issues.

@adaniels21487 adaniels21487 Cisco Integrated Management Console
Features:

- Pulls all hardware items and stores them in entPhysical and components
- A critical alarm is raised if a component fails
- Creates sensors for all graphable items.
129205a
@laf

Querying about adding this to ent-physical rather than it's own modules.

@adaniels21487
Contributor

Hi @laf
Sorry for the delay. I have no issues with this being in ent-physical.
I will get on it now.

Aaron

@adaniels21487 adaniels21487 - Moved cisco-cimc into the entity-physical for discovery and polling.
322edb6
@laf
Member
laf commented Sep 27, 2016

All good with me with one exception: We probably want to switch the entity-physical to use includes now as that's a big chunk of code :) Feel free to not do this now and I'll sort it out.

@librenms/reviewers anyone else?

@laf laf added this to the September release milestone Sep 27, 2016
@adaniels21487
Contributor

hi @laf
Good call on splitting it out. If you're happy to wait a day or so I'll split it out now.
I'd like to investigate the 52 scrutinizer issues as well.

Aaron

@laf laf removed this from the September release milestone Sep 28, 2016
@laf
Member
laf commented Sep 28, 2016

No probs, we have a release due this weekend so I've removed this from the milestone for that as we won't be merging anything except bug fixes or small fixes after today.

@f0o
Member
f0o commented Oct 5, 2016

Any updates to this?

@f0o
f0o approved these changes Oct 5, 2016 View changes
@adaniels21487 adaniels21487 - Split out entity-physical into separate modules
c9a0c1b
@adaniels21487
Contributor

Hi @f0o
Yes, Sorry for the delay. I have split out the code, it all looks good on a couple of installs I run. But I'd like some further testing.
On my installs I can see inventory data from IOS and IOS-XE devices.

If testing is ok, this should be good to go.

Thanks,
Aaron

@adaniels21487 adaniels21487 - Merged master
Conflicts:
	includes/discovery/entity-physical.inc.php
088cf42
@laf laf Small updates and oid fixes
a6c9ae2
@scrutinizer-notifier

The inspection completed: 11 new issues, 2 updated code elements

@laf laf merged commit a2563c5 into librenms:master Oct 6, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adaniels21487 adaniels21487 deleted the adaniels21487:issue-4252 branch Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment