IBM NOS Support #454

Merged
merged 4 commits into from Feb 14, 2015

Projects

None yet

2 participants

@Rosiak
Contributor
Rosiak commented Feb 14, 2015

Basic device support for a few IBM NOS devices.
Will add more as i get access to more devices.

@Rosiak Rosiak IBM NOS Support
Basic device support for a few IBM NOS devices.
Will add more as i get access to more devices.
9242246
@laf
Member
laf commented Feb 14, 2015

Some comments, mainly just code formatting:

includes/discovery/os/ibmnos.inc.php

Ideally you should just do an or in the if statement so you won't need the elseif, i.e:
if(blah || bleh)

On the if statement front, can you follow the below format (we should document this):

if(blah) {

} elseif(bleh) {

} else {

}

Indentations should be 4 spaces rather than tabs as well.

If you wouldn't mind sorting those out I can merge the changes for you.

Rosiak added some commits Feb 14, 2015
@laf laf merged commit f827bba into librenms:master Feb 14, 2015

1 check passed

Scrutinizer 2 new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment