Add OS detection for macOS Sierra #4557

Merged
merged 2 commits into from Sep 23, 2016

Projects

None yet

5 participants

@florianbeer
Contributor

Darwin Kernel Version 16

@florianbeer florianbeer Add OS detection for macOS Sierra
Darwin Kernel Version 16
2bfcc01
@murrant

Can you add a test too? tests/OSDiscovery.php

Please I include the actual sysDescr and sysObjectID from the device.

@florianbeer
Contributor

sysDescr: Darwin hostname.local 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20 PDT 201 6; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64

How do I get the sysObjectID? snmpwalk only gives me the following string, but I guess that's not what's needed here: SNMPv2-MIB::sysObjectID.0 = OID: NET-SNMP-MIB::netSnmpAgentOIDs.255

@florianbeer
Contributor

I think I've got it now:

system.sysObjectID.0 = .1.3.6.1.4.1.8072.3.2.255

@florianbeer florianbeer Add OS discovery test for macOS Sierra
fe5c9fb
@Rosiak
Contributor
Rosiak commented Sep 23, 2016

Just a quick question @murrant, is it valid to use 1.3.6.1.4.1.8072.3.2.255, since this is documented as "unknown"?

@scrutinizer-notifier

The inspection completed: No new issues

@murrant
Contributor
murrant commented Sep 23, 2016 edited

@rosiak for tests yes! but we do not want to use it solely in our detection code. Having the full sysObjectID in tests will help identify when we make mistakes like that.

@murrant murrant merged commit 3272b82 into librenms:master Sep 23, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment