Raise version size in db to 70 char #4656

Merged
merged 3 commits into from Oct 6, 2016

Projects

None yet

6 participants

@xbeaudouin
Contributor

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Some version numbers are sometimes more that 64 chars (for example : zimbra-cluebringer 2.1.0.0.cf484f1b93cf9965886cc89d33bdeee9c26426cb-1zimbra8.7b1.14.04).

xavier.beaudouin Raize version size in db to 70 char because there is some version tha…
…t use more than 64 chars example : zimbra-cluebringer 2.1.0.0.cf484f1b93cf9965886cc89d33bdeee9c26426cb-1zimbra8.7b1.14.04
f2fc345
@laf laf added this to the October release milestone Sep 29, 2016
@laf
Member
laf commented Sep 29, 2016

We can go up to 255 chars for varchar without using additional space in mysql so I propose we increase this to 120 or 160 to cover us further. @librenms/reviewers

@murrant murrant changed the title from Raize version size in db to 70 char to Raise version size in db to 70 char Sep 29, 2016
@laf laf added the Schema label Oct 3, 2016
@laf
Member
laf commented Oct 3, 2016

@librenms/reviewers thoughts on upping this to something like 120 - 160?

@paulgear
Member
paulgear commented Oct 4, 2016

If we can go up to 255 chars for varchar without using additional space in mysql, I can't see any reason we wouldn't make it 255.

@f0o
Member
f0o commented Oct 5, 2016

👍 to 255

@laf
Member
laf commented Oct 5, 2016
xavier.beaudouin Bump to 255 :) deb9f4c
@xbeaudouin
Contributor

Just updated :D

xavier.beaudouin Renamed the SQL update
652ade1
@scrutinizer-notifier

The inspection completed: No new issues

@laf laf removed the Blocker label Oct 6, 2016
@laf laf merged commit 366bbaf into librenms:master Oct 6, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment