fix: Fixed SQL query for bgpPeers check to remove stale sessions #4697

Merged
merged 1 commit into from Oct 2, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Oct 1, 2016 edited

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

The db schema for bgpPeers context_name is NULL. However the query checks for ='' so never matches. I did think about not allowing NULL but then we'd have to set context_name in many other places and it genuinely should be allowed to be NULL here anyway.

Fixes: #4635

@laf laf fix: Fixed SQL query for bgpPeers check to remove stale sessions
a85fdd0
@laf laf added the Bug label Oct 1, 2016
@scrutinizer-notifier

The inspection completed: No new issues

@f0o
f0o approved these changes Oct 2, 2016 View changes
@f0o f0o merged commit 06b0906 into librenms:master Oct 2, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-4635 branch Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment