Small poller improvements, removes unecessary queries / execs #4741

Merged
merged 1 commit into from Oct 15, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Oct 6, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Been through ./poller.php -h HOSTNAME -r -f -v to see what modules were trying to run queries / execs that a linux box didn't support and tried to stop that happening.

@laf laf Small poller improvements, removes unecessary queries / execs
7033d32
@scrutinizer-notifier

The inspection completed: 2 new issues

@laf
Member
laf commented Oct 11, 2016

bump

- $ipmi['password'] = get_dev_attrib($device, 'ipmi_password');
- $ipmi['type'] = get_dev_attrib($device, 'ipmi_type');
- echo 'Fetching IPMI sensor data...';
+ if ($ipmi['host'] = $attribs['ipmi_hostname']) {
@murrant
murrant Oct 14, 2016 Contributor

Why not build the attribs cache into thte get_dev_attrib() function?

@laf
laf Oct 14, 2016 Member

I'll leave that refactor to another time but yes it's a good idea as at present we just get them all at the start of the poll.

@Rosiak
Rosiak approved these changes Oct 14, 2016 View changes

Tested, no issues seen 👍

@murrant murrant merged commit d86b393 into librenms:master Oct 15, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:small-poller-improvements branch Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment