fix: top widget multiple instances #4757

Merged
merged 3 commits into from Oct 14, 2016

Projects

None yet

4 participants

@crcro
Contributor
crcro commented Oct 9, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

fix #4739

laf and others added some commits Oct 7, 2016
@laf laf Set defaults dd4daf2
@crcro crcro fixed for multiple widgets
0714703
@laf
Member
laf commented Oct 9, 2016

Seems to cause empty widgets for me (for the top devices one that is). Tested on two installs

@laf laf added the Blocker label Oct 9, 2016
@crcro
Contributor
crcro commented Oct 9, 2016

Did you input the number of devices and polling time? (there are no default values)

On Oct 9, 2016, at 17:13, Neil Lathwood notifications@github.com wrote:

Seems to cause empty widgets for me (for the top devices one that is). Tested on two installs


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@laf
Member
laf commented Oct 9, 2016

No I didn't we need to have defaults in the display prt of the code. We shouldn't make users set the options they don't need.

@crcro
Contributor
crcro commented Oct 9, 2016

sure, i'll make some default values, would 5 devices with 5 minutes be a good default?

@laf
Member
laf commented Oct 9, 2016

I'd say 5 devices and 15 mins.

@laf laf added WebUI and removed Blocker labels Oct 14, 2016
@laf laf merged commit 610c933 into librenms:master Oct 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scrutinizer-notifier

The inspection completed: No new issues

@laf
Member
laf commented Oct 14, 2016

image

@crcro crcro deleted the crcro:fix-top-widget branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment