refactor: populate native vlans in the ports_vlan table for cisco devices too #4805

Merged
merged 1 commit into from Oct 19, 2016

Projects

None yet

3 participants

@murrant
Contributor
murrant commented Oct 15, 2016 edited

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Store vlans in temp array indexed by ifIndex instead of dot1q base id
Improves vlan accuracy, ifVlan is not very reliable

@murrant murrant refactor: populate native vlans in the ports_vlan table for cisco dev…
…ices too

Store vlans in temp array indexed by ifIndex instead of dot1q base id
aadbaec
@scrutinizer-notifier

The inspection completed: 2 new issues

@laf
Member
laf commented Oct 15, 2016

All good with me.

@ekoyle fancy testing this?

@laf laf merged commit 4ff9e84 into librenms:master Oct 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@murrant murrant deleted the murrant:cisco-vlan-cleanup branch Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment