Fix the detection of NX-OS fan names #4864

Merged
merged 1 commit into from Oct 25, 2016

Projects

None yet

4 participants

@geordish
Contributor

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

The patch that was commited to add this was modified so that the method of detecting the name of the fan was broken. This restores that.

@geordish geordish Fix the detection of NX-OS fan names
63bf929
@scrutinizer-notifier

The inspection completed: No new issues

@laf
Member
laf commented Oct 24, 2016

Tested and works fine - one question though and it might not be this sensor that's broken but our install at work has gaps in the data for Fan state as they get added and removed every few hours.

It could be that we're not running against master (I manually added your previous NXOS patches to test) but thought it's worth asking.

image

@laf laf added the Discovery label Oct 24, 2016
@geordish
Contributor

That is odd. Same set of patches, and I don't see the same thing:
image

(gaps at the beginning are where I was messing around getting this patch working)

Does running the discovery manually tell you anything interesting?

@laf
Member
laf commented Oct 25, 2016

Running multiple discovery / poller one after the other doesn't cause it to happen. here's logs from it doing so before though:

2016-10-25 08:19:52     System  Sensor Deleted: state cefcFanTrayOperStatus 534 Fan Module-1
2016-10-25 08:19:52     System  Sensor Deleted: state cefcFanTrayOperStatus 535 Fan Module-2
2016-10-25 08:19:52     System  Sensor Deleted: state cefcFanTrayOperStatus 536 Fan Module-3
2016-10-25 08:19:52     System  Sensor Deleted: state cefcFanTrayOperStatus 537 Fan Module-4
2016-10-25 06:15:05     System  state sensor has changed from to 2
2016-10-25 06:15:05     System  state sensor has changed from to 2
2016-10-25 06:15:05     System  state sensor has changed from to 2
2016-10-25 06:15:05     System  state sensor has changed from to 2
2016-10-25 06:12:53     System  Sensor Added: state cefcFanTrayOperStatus 534 Fan Module-1
2016-10-25 06:12:53     System  Sensor Added: state cefcFanTrayOperStatus 535 Fan Module-2
2016-10-25 06:12:53     System  Sensor Added: state cefcFanTrayOperStatus 536 Fan Module-3
2016-10-25 06:12:53     System  Sensor Added: state cefcFanTrayOperStatus 537 Fan Module-4

I'll merge for now as I expect this is our local setup.

@laf laf merged commit 3ed80ab into librenms:master Oct 25, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geordish geordish deleted the geordish:nxos-fix-fan-names branch Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment