refactor: Default to only using mysqli #4915

Merged
merged 3 commits into from Nov 11, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Nov 1, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Remove deprecated mysql() calls and defaults to using mysqli().

@laf laf refactor: Default to only using mysqli
13bc507
@f0o
f0o approved these changes Nov 1, 2016 View changes
@laf laf Remove includes/dbFacile.mysql.php
994d83d
@laf
Member
laf commented Nov 1, 2016

Actually removed the file :/

@murrant
murrant approved these changes Nov 9, 2016 View changes

Looks good.

Fun Facts:
I discovered that our predecessors actually converted the class based dbFacile to functional style. dbFacile 0.4.3 is from ~2009 also.

includes/common.php
@@ -398,11 +398,7 @@ function mres($string)
{
// short function wrapper because the real one is stupidly long and ugly. aesthetics.
global $config, $database_link;
@murrant
murrant Nov 9, 2016 Contributor

Not important, but you could drop the $config global here.

@laf laf updated mres() function to remove $config global
a8ed196
@laf
Member
laf commented Nov 9, 2016

Updated

@scrutinizer-notifier

The inspection completed: 5 new issues, 18 updated code elements

@murrant murrant merged commit cc01969 into librenms:master Nov 11, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:remove-mysql branch Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment