refactor of daily.sh #4920
Merged
refactor of daily.sh #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored code of daily.sh. Replaced -ne with "!=", "[" with "[[", enforced better quotes usage, moved daily.php calls to a dedicated function, added support for using $config['log_dir'] from config.php for setting the log directory. Defaults to the value of $config['install_dir'] . '/logs' if $config['log_dir'] is not set.
|
Auto-Deploy finished, Test PR at http://4920.ci.librenms.org or https://4920.ci.librenms.org |
Major refactor, added name to authors list :p
|
Auto-Deploy finished, Test PR at http://4920.ci.librenms.org or https://4920.ci.librenms.org |
|
The inspection completed: No new issues |
|
Tested and works for me. CentOS 7. bash --version
GNU bash, version 4.2.46(1)-release (x86_64-redhat-linux-gnu)What have you tested against @Gorian ? |
laf
approved these changes
Nov 3, 2016
f0o
approved these changes
Nov 3, 2016
|
@laf also CentOS7, same bash version. |
|
Works for me as far as I can tell. Debian Jessie |
|
I think we need some older distros to test this on. |
murrant
approved these changes
Nov 9, 2016
|
Tested on |
|
Tagged to merge in 48 hours. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note
Refactored code of daily.sh. Replaced -ne with "!=", "[" with "[[", enforced better quotes usage, moved daily.php calls to a dedicated function, added support for using $config['log_dir'] from config.php for setting the log directory. Defaults to the value of $config['install_dir'] . '/logs' if $config['log_dir'] is not set. Properly moved all code not in a dedicated function to main().