refactor: Tidy up mibs V-Z #4979

merged 1 commit into from Nov 17, 2016


None yet

4 participants

laf commented Nov 12, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

I'm pretty certain this won't lead to breaking changes.

For all the mibs I've moved I've grepped the names of them through the entire install dir to make sure:

  1. They aren't imported by other mibs in sub directories already.

  2. Any OS' that rely on them I faked the os name to localhost and ran pollers to make sure the snmp commands built up the calls with the correct dirs.

This PR adds eatonups definitions, we had code for detection, unit testing and sensors but no definition. It's here because it's part of the mib move.

I've deleted numerous unused mibs, again confirmed by grepping the names of them through the entire install dir which includes check they aren't imported from other mibs.

Added the code back in that allows specifying mib dirs as part of the os definition as we had different vendors share the same mibs so couldn't use groups (UPS mib).

@laf laf refactor: Tidy up mibs V-Z

The inspection completed: 5 new issues, 1 updated code elements

murrant commented Nov 15, 2016

This looks good to me, but I'm not really sure how to test it :(

laf commented Nov 15, 2016


I've tried to be as careful as possible by checking the mibs themselves. This one is a bit easier as we don't have to worry about dependencies on another MIB that may be in a different sub dir already.

Tried to limit the damage to sticking with a small number of mibs to start with.

murrant commented Nov 17, 2016

Nothing broken on my setup. Merging. @librenms/reviewers Keep an eye for reports.

@murrant murrant merged commit d389069 into librenms:master Nov 17, 2016

2 checks passed

Auto-Deploy Build finished.
continuous-integration/travis-ci/pr The Travis CI build passed
@laf laf deleted the laf:mibs-v-z branch Nov 17, 2016
laf commented Nov 17, 2016

Thanks, will hit some more in the morning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment