fix: Strip out " returned from Proxmox application #4908 #5003

Merged
merged 2 commits into from Nov 21, 2016

Projects

None yet

4 participants

@laf
Member
laf commented Nov 15, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Fixes #4908

@laf laf fix: Strip out " returned from Proxmox application
ce2f580
@laf laf added the Bug label Nov 15, 2016
@laf
Member
laf commented Nov 20, 2016

bump

@@ -64,6 +64,7 @@ function proxmox_vm_exists($i, $c, &$pmxcache)
$pmxcache = array();
foreach ($pmxlines as $vm) {
+ $vm = preg_replace('/"/', '', $vm);
@murrant
murrant Nov 21, 2016 Contributor

Why not just str_replace?

@laf laf updated to str_replace
8d44f4e
@scrutinizer-notifier

The inspection completed: No new issues

@murrant murrant merged commit 63569b5 into librenms:master Nov 21, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:issue-4908 branch Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment