update some devices to disable poller/disco modules by default #5010

Merged
merged 2 commits into from Dec 12, 2016

Projects

None yet

5 participants

@laf
Member
laf commented Nov 17, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Covers more cisco devices + some juniper.

I expect they may give users the biggest benefit.

@laf laf update some devies to disable poller/disco modules by default
6207554
@murrant
Contributor
murrant commented Nov 19, 2016

What do you think about disabling some of these globally and enabling them per OS?

@laf
Member
laf commented Nov 19, 2016

Always nervous :)

We can do. Things like cisco-ace-* only are used for os' which are in the cisco group. I'll take another look.

@laf laf turned off certain vendor specific modules in defaults
5f15621
@laf
Member
laf commented Nov 19, 2016

Set a lot of vendor specific modules to be off in defaults then enabled per os.

@scrutinizer-notifier

The inspection completed: No new issues

@murrant murrant changed the title from update some devies to disable poller/disco modules by default to update some devices to disable poller/disco modules by default Nov 22, 2016
@murrant
Contributor
murrant commented Nov 22, 2016

I'll try to test this sometime this week.

@Rosiak
Contributor
Rosiak commented Nov 30, 2016 edited

I should be able to test this tomorrow.

@laf
Member
laf commented Dec 4, 2016

bump

@laf laf merged commit 8cc66ec into librenms:master Dec 12, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@laf laf deleted the laf:default-modules-1 branch Dec 12, 2016
@VimCommando VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017
@laf @VimCommando laf + VimCommando refactor: update some devices to disable poller/disco modules by defa…
…ult (#5010)
6ce4a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment