Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some devices to disable poller/disco modules by default #5010

Merged
merged 2 commits into from Dec 12, 2016

Conversation

laf
Copy link
Member

@laf laf commented Nov 17, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Covers more cisco devices + some juniper.

I expect they may give users the biggest benefit.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5010.ci.librenms.org or https://5010.ci.librenms.org

@murrant
Copy link
Member

murrant commented Nov 19, 2016

What do you think about disabling some of these globally and enabling them per OS?

@laf
Copy link
Member Author

laf commented Nov 19, 2016

Always nervous :)

We can do. Things like cisco-ace-* only are used for os' which are in the cisco group. I'll take another look.

@laf
Copy link
Member Author

laf commented Nov 19, 2016

Set a lot of vendor specific modules to be off in defaults then enabled per os.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5010.ci.librenms.org or https://5010.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@murrant murrant changed the title update some devies to disable poller/disco modules by default update some devices to disable poller/disco modules by default Nov 22, 2016
@murrant
Copy link
Member

murrant commented Nov 22, 2016

I'll try to test this sometime this week.

@Rosiak
Copy link
Member

Rosiak commented Nov 30, 2016

I should be able to test this tomorrow.

@laf
Copy link
Member Author

laf commented Dec 4, 2016

bump

@laf laf merged commit 8cc66ec into librenms:master Dec 12, 2016
@laf laf deleted the default-modules-1 branch December 12, 2016 14:26
VimCommando pushed a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants