New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some devices to disable poller/disco modules by default #5010

Merged
merged 2 commits into from Dec 12, 2016

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Nov 17, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Covers more cisco devices + some juniper.

I expect they may give users the biggest benefit.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Nov 17, 2016

Auto-Deploy finished, Test PR at http://5010.ci.librenms.org or https://5010.ci.librenms.org

@murrant

This comment has been minimized.

Member

murrant commented Nov 19, 2016

What do you think about disabling some of these globally and enabling them per OS?

@laf

This comment has been minimized.

Member

laf commented Nov 19, 2016

Always nervous :)

We can do. Things like cisco-ace-* only are used for os' which are in the cisco group. I'll take another look.

@laf

This comment has been minimized.

Member

laf commented Nov 19, 2016

Set a lot of vendor specific modules to be off in defaults then enabled per os.

@LibreNMS-CI

This comment has been minimized.

LibreNMS-CI commented Nov 19, 2016

Auto-Deploy finished, Test PR at http://5010.ci.librenms.org or https://5010.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

scrutinizer-notifier commented Nov 19, 2016

The inspection completed: No new issues

@murrant murrant changed the title from update some devies to disable poller/disco modules by default to update some devices to disable poller/disco modules by default Nov 22, 2016

@murrant

This comment has been minimized.

Member

murrant commented Nov 22, 2016

I'll try to test this sometime this week.

@Rosiak

This comment has been minimized.

Contributor

Rosiak commented Nov 30, 2016

I should be able to test this tomorrow.

@laf

This comment has been minimized.

Member

laf commented Dec 4, 2016

bump

@laf laf merged commit 8cc66ec into librenms:master Dec 12, 2016

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@laf laf deleted the laf:default-modules-1 branch Dec 12, 2016

VimCommando added a commit to VimCommando/librenms that referenced this pull request Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment